Hi,
+ self._bundle_id = activity_info.bundle_id
+ self._version = activity_info.version
+ self._favorite = activity_info.favorite
Do we really need to store favorite in a member variable? Cannot just
use whatever value has favorite when activity-changed?
+ self._favorite_item = MenuItem(_('Add to ring'))
You are defining this same string twice. Why not just create the
_favorite_item in the constructor as you are doing, but without
passing any label? After the menuitem is created, you can just call
_update_favorite_item() and that would set the label and the color.
Thanks,
Tomeu
_______________________________________________
Sugar mailing list
[email protected]
http://lists.laptop.org/listinfo/sugar
