Can somebody review this patch? I'd like to implement the date field in the activity list, but that will conflict heavily with this patch.
Thanks, Tomeu 2008/5/13 Tomeu Vizoso <[EMAIL PROTECTED]>: > [re-adding sugar to cc] > > 2008/5/12 Eben Eliason <[EMAIL PROTECTED]>: >> I glanced at this, and I *think* that it does what I want it to, but I >> wanted to clarify. (The comment "# Activities to be automatically >> added to the ring after an upgrade" worried me). >> >> What I expect this to do is merge a list of specified default >> activities D with a list of favorite activities F, such that the ring >> contains F ∪ D, where F is the up to date list of user chosen >> favorites and D is a list of defaults as specified /by the latest >> upgrade/. So I guess a clear point I'm questioning is if the >> activities.defaults is a) specified by the countries at time of >> customization and b) read from an "activity pack" upon future updates, >> such that it is not actually a hard coded list (except, perhaps, as a >> default when no other list has been provided via the above methods). > > Yes, the activities.defaults file is read and merged in the way you > describe every time it changes. This will happen in the scenarios you > mentioned. > >> It also appears that that the implementation performs the merge of F >> and D once each time a new defaults file appears (via an activity pack >> update), which is desired behavior, but I just wanted to confirm that. > > Right. > >> PS. Can someone give me a clearer idea of the "activity pack" and how >> they actually work? My personal interpretation of the idea is that it >> consists a bundle of activity bundles, and a file which specifies the >> new activities.defaults. I furthermore assume that the >> activities.defaults file included should *only* reference activities >> included in the activity pack. Could I get confirmation on this? > > Yes, this is my understanding as well, although I have no first-hand > info on that. > > Thanks, > > Tomeu > _______________________________________________ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar