On Sat, May 24, 2008 at 5:02 PM, Eben Eliason <[EMAIL PROTECTED]> wrote: > I'm responding with a few things to check on. I don't have a two > button mouse, so I did my testing with the left-click and then changed > it before committing, but then realized that there could be > complications: > > 1) If the event handler for the widget/button gets called before that > of the invoker, then the button behavior will be invoked even on > right-click, which is undesirable. We might need to change the > connections on the various widgets to connect-after, or alternately > verify within the current handlers that event.button == 1. These > changes could be a separate patch, for clarity. > > 2) I didn't return False from the event handler in the WidgetInvoker > class, which means regardless of (1), right-clicking on toolbar > buttons/frame elements could be broken. If this is the case, this > should be fixed in the current patch.
Pushed with minor edits to rebase and fix the issues above. Thanks, Tomeu _______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
