r+, please add a \n after the assert. (thanks for drawing attention on this again, and sorry for the delay)
Marco On Mon, Jun 23, 2008 at 1:28 PM, Martin Dengler <[EMAIL PROTECTED]> wrote: > At the risk of being annoying, may I draw attantion to this patch > again? It's a dependency of one of the patches to #7248 that I'd like > to be able to get in for the upcoming Sugar release... > > On Thu, Jun 12, 2008 at 01:15:03AM +0100, Martin Dengler wrote: >> --- >> src/sugar/graphics/icon.py | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/sugar/graphics/icon.py b/src/sugar/graphics/icon.py >> index d22b412..65f194b 100644 >> --- a/src/sugar/graphics/icon.py >> +++ b/src/sugar/graphics/icon.py >> @@ -580,8 +580,8 @@ class CanvasIcon(hippo.CanvasBox, hippo.CanvasItem): >> >> palette = property(get_palette, set_palette) >> >> -def get_icon_state(base_name, perc): >> - step = 5 >> +def get_icon_state(base_name, perc, step=5): >> + assert step > 0, 'get_icon_state(): step must be positive' >> strength = round(perc / step) * step >> icon_theme = gtk.icon_theme_get_default() >> > > _______________________________________________ > Sugar mailing list > [email protected] > http://lists.laptop.org/listinfo/sugar > > _______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
