Not sure if this has been reported to the Sugar team... Morgan
---------- Forwarded message ---------- From: dann frazier <[EMAIL PROTECTED]> Date: Tue, Jul 8, 2008 at 00:45 Subject: [Debian-olpc-devel] Bug#489817: sugar-toolkit: gsm_xsmp_init implicitly converted to pointer To: [EMAIL PROTECTED] Package: sugar-toolkit Version: 0.81.5-1 Severity: serious Tags: patch Usertags: implicit-pointer-conversion Our automated buildd log filter[1] detected a problem that is likely to cause your package to segfault on architectures where the size of a pointer is greater than the size of an integer, such as ia64 and amd64. Function `gsm_xsmp_init' implicitly converted to pointer at _sugarext.c:896 Function `gsm_xsmp_init' implicitly converted to pointer at _sugarext.c:896 This is often due to a missing function prototype definition. For more information, see [2]. Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity. [1] http://people.debian.org/~dannf/check-implicit-pointer-functions [2] http://wiki.debian.org/ImplicitPointerConversions -- dann frazier _______________________________________________ Debian-olpc-devel mailing list [EMAIL PROTECTED] http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel
--- sugar-toolkit-0.81.5.orig/src/sugar/_sugarext.c 2008-06-20 10:53:45.000000000 -0600 +++ sugar-toolkit-0.81.5/src/sugar/_sugarext.c 2008-07-07 16:08:04.000000000 -0600 @@ -14,6 +14,7 @@ #include "sugar-preview.h" #include "sexy-icon-entry.h" #include "gsm-session.h" +#include "gsm-xsmp.h" #define EGG_SM_CLIENT_BACKEND_XSMP #include "eggsmclient.h"
_______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
