On Thu, Sep 11, 2008 at 2:39 AM, Marco Pesenti Gritti
<[EMAIL PROTECTED]> wrote:
> On Wed, Sep 10, 2008 at 2:58 PM, Tomeu Vizoso <[EMAIL PROTECTED]> wrote:
>>> * I wonder if it would be easier to add a "builtin" journal activity
>>> to the registry, instead of special casing the model.
>>
>> Not sure, a couple of ifs may be less confusing.
>
> Hmmm not fully convinced, but I don't have a strong feeling. Something
> we can easily refactor anyway.
>
> The patch seem to have caused some pylint regressions:
>
> http://buildbot.sugarlabs.org/builders/fedora9-x86_64-quick/builds/177/steps/pylint/logs/stdio
One of the warnings here is actually due to:
if ds_object.get_file_path(fetch=False) is None:
file_path = ''
else:
file_path = ds_object._file_path
I guess that's not what you meant.
file_path = ds_object.get_file_path(fetch=False)
if not file_path:
file_path = ''
Right?
Marco
_______________________________________________
Sugar mailing list
[email protected]
http://lists.laptop.org/listinfo/sugar
