On Fri, Oct 17, 2008 at 6:11 PM, Eben Eliason <[EMAIL PROTECTED]> wrote: > This is a set of patches I worked on recently, and need to rebase on > the latest jhbuild before I post them officially. I wanted to expose > them for comments before I put in that effort, since there are no > doubt other things that will need to be changed upon review. > > Thanks! > > - Eben > > PS. I just noticed upon attaching that the first isn't actually a > clipboard patch, but it was part of a sprint on clipboard and > drag'n'drop in general, so I include it.
[PATCH] Lock cursor to center of icons in favorites view on drag (#7408) Looks good, you can as well calculate again the hot point from the pixbuf in the context, instead of adding two private members more to the class. [PATCH] Title clippings appropriately eg. "Text clipping" (#5751) OK, you may want to add a TRANS comment with a hint to translators. [PATCH] Add descriptions to clippings (#5751) Not sure if we should do the formatting in model/clipboardobject.py, that looks to me more like a presentation issue so should live in the view classes? [PATCH] Highlight clipboard on drag (#8604) Awesome! [PATCH] Prevent duplicate clippings on drag within clipboard (#8606) Sounds good as a temporary measure, but I think that Gtk+ has support in its trays for reordering elements with DnD. Or it may be some extension to gtk+? Worth investigating. Thanks, Tomeu _______________________________________________ Sugar mailing list [email protected] http://lists.laptop.org/listinfo/sugar
