Hi Gerald, thanks, I reworked the patch a little and included it. For the next time please try to separate style changes from content changes (there is no need to run astyle before submitting a patch).
Best regards, Michael Am 28.07.2017 um 16:59 schrieb Richter Gerald via sumo-devel: > Hi all, > > second attempt. > > The attachment holds a diffpatch against svn revision trunk@25375: "Changed > name from GNEDialog_FixStoppingPlaces to GNEDialog_FixAdditionalPositions. > Refs #3072" > > to allow for conversion of given speed restrictions to SI [m/s] in > laneSections when the unit attribute is being used, which is defined with > OpenDrive xsd spec. v1.4. The patch was generated with mercurial's diff > --svn, and successfully reapplied to the svn tree with svn patch. Before > diffing it was run through astyle by using the python tool. A lot of > reformattings were the result, surprisingly. > > I have not found a procedure documented in the dev-wiki on how I could submit > this for revision, and last time I accidentally pushed to svn, so I decided > to send it here. The wiki says one should post patches here. So my first > attempt failed due to exceeded attachment size. - how big max. are they > supposed to be? > > Please add the patch to the codebase. if I had to pick a commit message, it > would be: > > [netimport] (xodr v1.4 feat.) convert speed to SI [m/s], on given > laneSection/speed/unit attribute > > But anyhow, the question is: if I push something to the svn trunk will it > simply get reviewed and all is fine, or do I have to commit in a special way > to a separate branch or something? > > best regards, > Gerald. > > -- > > > GERALD RICHTER Scientist Dynamic Transportation Systems Center for Mobility > Systems AIT Austrian Institute of Technology GmbH Giefinggasse 2 | 1210 > Vienna | Austria T +43 50550-6072 | M +43 664 2106779 > gerald.rich...@ait.ac.at<mailto:gerald.rich...@ait.ac.at> | > www.ait.ac.at<http://www.ait.ac.at/> > FN: 115980 i HG Wien | UID: ATU14703506 > www.ait.ac.at/Email-Disclaimer<http://www.ait.ac.at/Email-Disclaimer> > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > sumo-devel mailing list > sumo-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/sumo-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ sumo-devel mailing list sumo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sumo-devel
