Excerpts from Rich Lane's message of Wed Jan 20 01:14:46 -0500 2010: > What do you think about doing the expansion in Index.parse_query, right > after the custom-search hook? That would save you from keeping track of > the unexpanded text. Otherwise this patch looks good to me.
Works for me. I hadn't even considered it, thinking the index is sacred code. Another side-effect of making this change is ParseErrors are now gracefully handled in search-list-mode where before they would have crashed sup because I wasn't thinking. Instead of returning false and flashing like in the previous patch, SearchManager#expand raises an ExpansionError, which parse_query re-raises as a ParseError. _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel
