Hi! While fixing the sup-dump vs. default sent source bug (see posted patch) I stumbled over the following pieces of code: 1. SentManager uses source_id of 9998 for the default sent source (lib/sup/sent.rb:52) 2. DraftManager uses a fixed source_id of 9999 (lib/sup/draft.rb:13,49) 3. SourceManager skips the source_id of SentManager and DraftManager while computing the id for a new source (lib/sup/source.rb:203)
Does that mean sup will blow up once I have more than ~10k sources? I'm already at > 5k sources (containing > 680k messages, took > 2 days to import), so this isn't just an academic exercise... Wouldn't it be better to (*) use small fixed source ids for SentManager/DraftManager and let SourceManager start above a number of reserved ids (say: 50)? Is there something in sup that depends on the non-special source ids not to have "holes" (or will waste resources in that case)? Another approach would be to make the SentManager/DraftManager source ids dynamic and add them to sources.yaml. Sascha (*) Read: Would you accept a patch that implements that new logic? -- http://sascha.silbe.org/ http://www.infra-silbe.de/
signature.asc
Description: PGP signature
_______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel
