Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011: > 0002-edit-message-mode-Add-an-optional-account-selector.patch
I've finally got around to reviewing some of these. The patch above seems to confuse possible email addresses, and user accounts. These do not line up as it is possible for each account to have multiple email addresses associated with it (using the alternates value in an account). I have only one account, and have alternates, so the account selector appears, but doesn't work due to the confusion. I've had a look through, but not found an easy way to fix that behaviour, so I'll leave it up to you as to how you want to do it. I imagine though that you would want to handle all the possible email addresses, so I've written an extra patch to do that, and pushed your patch and mine onto the (new) account_selector branch on gitorious. Please have a look and see if what I've done still works for you, and is what you meant. I also wondered whether to change the behaviour so that the account selector will only appear if there is more than one possible email address to choose from, but I thought it would be handy to be able to reset the From: header to your usual From: using the selector, rather than having to hand edit whatever was in the To: header that you are replying to. What do you think? I'll wait for you to review my changes before I merge this into next. (My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1) Hamish Downer _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel
