Hi,

I'm using svn sup and just recently started getting the following error
when getting new email without a proper message_id (patch is attached):

The problem was: 'can't convert nil into String' (error type TypeError)
A backtrace follows: /home/rick/sup/lib/sup/index.rb:323:in
`initialize': can't convert nil into String (TypeError)
        from /home/rick/sup/lib/sup/index.rb:323:in `new'
        from /home/rick/sup/lib/sup/index.rb:323:in `load_entry_for_id'
        from /home/rick/sup/lib/sup/util.rb:395:in `send'
        from /home/rick/sup/lib/sup/util.rb:395:in `method_missing'
        from /home/rick/sup/lib/sup/poll.rb:156:in `add_messages_from'
        from /home/rick/sup/lib/sup/imap.rb:178:in `each'
        from /home/rick/sup/lib/sup/imap.rb:163:in `upto'
        from /home/rick/sup/lib/sup/imap.rb:163:in `each'
         ... 28 levels...
        from /home/rick/sup/lib/sup.rb:68:in `reporting_thread'
        from /home/rick/sup/lib/sup/modes/thread-index-mode.rb:372:in
`load_n_threads_background'
        from /home/rick/sup/lib/sup/modes/thread-index-mode.rb:422:in
`load_threads'
        from /home/rick/sup/bin/sup:188

The problem is that the parse_header method is assigning @id the result
of an "if" statement.  However, the "else" part of the "if" statement is
always returning the result of Redwood::log (nil) rather than the
"sup-faked" message_id.

-- 
Rick
[EMAIL PROTECTED]
diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 82fddcf..8506df1 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -62,8 +62,8 @@ class Message
       if header["message-id"]
         sanitize_message_id header["message-id"]
       else
-        "sup-faked-" + Digest::MD5.hexdigest(raw_header)
         Redwood::log "faking message-id for message from [EMAIL PROTECTED]: [EMAIL PROTECTED]"
+        "sup-faked-" + Digest::MD5.hexdigest(raw_header)
       end
     
     date = header["date"]
_______________________________________________
sup-talk mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/sup-talk

Reply via email to