Hi Marcus,

Excerpts from Marcus Williams's message of Fri Nov 02 05:18:19 -0700 2007:
> This patch cleans up my last IMAP patch, and adds the
> each_raw_message_line method to both Maildir and IMAP so that you dont
> get an exception when you try to save a message to a file with an IMAP
> or maildir source.

This all looks great, except for the source_marked_read stuff, which is
only there as a nasty hack to avoid scanning mbox files twice (because
you can't tell if an mbox message is read or not until you go through
all the headers).

For non-mbox read/unread, it should be sufficient to simply set the flags
as you do in IMAP#raw_header.

If you get a chance, can you resubmit without that? I may have a chance
to clean it up in the next few days if not.

-- 
William <[EMAIL PROTECTED]>
_______________________________________________
sup-talk mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/sup-talk

Reply via email to