Hi Steve,
Thanks for the patch! A couple comments:
Reformatted excerpts from Steve Goldman's message of 2008-11-07:
> Suppose I have an alias "william" for "William Morgan
> <[EMAIL PROTECTED]>".
It might be nice to put this helpful explanatory text in the commit
message itself, so that it gets recorded along with the patch.
> + sort { |x,y| x_is_c = ContactManager.contact_for(x); y_is_c
> = ContactManager.contact_for(y); x_is_c && !y_is_c ? -1 : !x_is_c && y_is_c ?
> 1
I think you can express this more succinctly with something like
sort_by { |c| [ContactManager.contact_for(c) ? 1 : 0, c] }
which makes use of both sort_by (Ruby's answer to the Schwartizan
transform) and the fact that arrays are sorted element-by-element.
Other than that, looks good and I like the idea.
--
William <[EMAIL PROTECTED]>
_______________________________________________
sup-talk mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/sup-talk
