On Wed, Feb 12, 2020 at 05:25:56PM +0300, innerspacepilot wrote: > Why not just make runit systems run inside containers out of the box? > We are talking about one/two lines of code.
Likewise `lxc.signal.halt' only needs one/two lines of code. It is also a interface with well-defined semantics. Modifying runit source code touches the implementation, with all the potential coupling between modules and/or between submodules. So the increase in total complexity of the system is almost certainly smaller when using `lxc.signal.halt'. > Why can't we be just a little bit more friendly to each other? Let's see some more examples. Some daemons (eg. mysqld and php-fpm) use a signal other than SIGTERM for graceful shutdown, and s6 uses a `down-signal' file (similar to `lxc.signal.halt') for these daemons. Instead of modifying the daemons, we configure s6 specially; likewise, here I would definitely prefer `lxc.signal.halt'. -- My current OpenPGP key: RSA4096/0x227E8CAAB7AA186C (expires: 2020.10.19) 7077 7781 B859 5166 AE07 0286 227E 8CAA B7AA 186C
