Thank you! The patch looks fine, I'll be merging it shortly. Thanks again,
- C On Sun, 2010-06-27 at 23:33 -0700, Jeremy Grosser wrote: > Not a problem. I wrote a quick bit of documentation including a simple > example and pushed it to my github repository: > > http://github.com/synack/supervisor/commit/e6b14e4c05109c0eaba091d17a958f79f445f16e > > I also found a small omission in the patch I emailed where > reconnect_count was not getting incremented upon reconnect... This > could lead supervisor to getting stuck in a loop trying to reconnect > to the scribe server. I've fixed that here: > > http://github.com/synack/supervisor/commit/86ad41bcf521c217b204d7efe59c28e486ee29b0 > > On Fri, Jun 25, 2010 at 7:12 PM, Chris McDonough <[email protected]> wrote: > > Hi Jeremy, > > > > Thanks a lot for the patch! > > > > Could I tweak you into adding a documentation patch? The docs are in > > the "docs" subdirectory on the trunk. There is a "logging.rst" in there > > IIRC, which could be changed to include a description of the scribe > > URLs. > > > > On Fri, 2010-06-25 at 17:14 -0700, Jeremy Grosser wrote: > >> I've written a patch for supervisor that allows the user to configure > >> logging of stdout and stderr from child processes to Facebook's scribe > >> [1]. This patch is based upon trunk #975 although as far as I can > >> tell, it should apply cleanly to the 3.0a8 release as well. This patch > >> requires a few extra dependencies be added, although it should allow > >> supervisord to function normally without scribe support if they are > >> not available. Debian packages for these components are available from > >> Digg's open source mirror [2]. > >> > >> - scribe > >> - python-thrift > >> - thrift-fb303 > >> > >> Usage: > >> (stdout|stderr)_logfile=scribe://scribe_address[:scribe_port]/[scribe_category] > >> > >> Example: > >> > >> [program:scribetest] > >> command=/tmp/scribetest.py > >> stdout_logfile=scribe://127.0.0.1/supervisor_test_stdout > >> stderr_logfile=scribe://127.0.0.1/supervisor_test_stderr > >> > >> I've attached a copy of the patch to this message and have also pushed > >> it to my supervisor git repository [3] on github. > >> > >> > >> [1] http://github.com/facebook/scribe > >> [2] http://about.digg.com/opensource/ops > >> [3] > >> http://github.com/synack/supervisor/commit/8b399029b510018688ed76a53154fc582d1ede5f > >> > >> -- > >> Jeremy Grosser > >> _______________________________________________ > >> Supervisor-users mailing list > >> [email protected] > >> http://lists.supervisord.org/mailman/listinfo/supervisor-users > > > > > > > _______________________________________________ Supervisor-users mailing list [email protected] http://lists.supervisord.org/mailman/listinfo/supervisor-users
