-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/16/2010 10:22 AM, Rob Guttman wrote:
> All, I provided Anton with a patch to pidproxy.py that handles > services/processes that have multiple child process (without using > pidfiles). He says it's working for him. So I've now forked supervisor and > applied my patch: > > https://github.com/robguttman/supervisor > > Not sure if this was the best way to submit my patch for future release > consideration so I'm also attaching the patch file and full pidproxy.py > file. I welcome feedback on the patch. Process-wise, now that supervisor is hosted on github, you should just be able to create a "pull request" for your fork, which the maintainers can then either merge directly or else provide feedback. WRT the implementation: iterating over the 'status' file for every process on the system seems pretty expensive. Wouldn't this use case be a good fit for process groups? E.g., have the proxy call 'os.setpgrp()' at startup, which implicitly sets the pgid for all its children as they are created; later, when signalling the children, use 'os.killpg(os.getpid(0), sig)'. Tres. - -- =================================================================== Tres Seaver +1 540-429-0999 [email protected] Palladion Software "Excellence by Design" http://palladion.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0KRBwACgkQ+gerLs4ltQ6sqQCgrAVp0rjwiR9vZFrDdY4/l6qK yikAoLL78lypdpkTc1ypVGOcXdYWJ3rH =dQ5M -----END PGP SIGNATURE----- _______________________________________________ Supervisor-users mailing list [email protected] http://lists.supervisord.org/mailman/listinfo/supervisor-users
