[pfSense Support] update_file.sh overwrites captiveportal.inc

[Frimmel, Ivan \(ISS South Africa\)]

HI ..   No sure if this is a bug .. or a feature request, so I haven’t logged a ticket yet.   I just realized why I need to keep disabling captiveportal then goto console, drop to shell, disable captive portal do upgrade from .gz file to recover.   When doing an update_file.sh the very first file it attempts to pull down is captiveportal.inc. IF the WAN connection is not up, it looks like it still overwrites this file, even if it doesn’t get a new file. This in turn breaks captiveportal, which means I can’t access the firewall at all except through the console, from where I either need to do a upgrade or another update_file.sh which then fixes things again.   Could we not add a simple hash check on the files that the script downloads ? Or at the very least get the script to check that it actually downloaded something before trashing the existing file?   Thinking about it .. I guess later on when the firmware update mechanism is activated this is something we would need, i.e. internal file version check, compare, d/l(if older), hash and size check, assemble update package, replace/apply all diffs?   Tx Ivan.