Author: brett
Date: Thu Mar 30 20:25:25 2006
New Revision: 390323

URL: http://svn.apache.org/viewcvs?rev=390323&view=rev
Log:
merge r390296 from trunk

Modified:
    
maven/surefire/branches/surefire-testng/surefire-api/src/main/java/org/apache/maven/surefire/report/XMLReporter.java

Modified: 
maven/surefire/branches/surefire-testng/surefire-api/src/main/java/org/apache/maven/surefire/report/XMLReporter.java
URL: 
http://svn.apache.org/viewcvs/maven/surefire/branches/surefire-testng/surefire-api/src/main/java/org/apache/maven/surefire/report/XMLReporter.java?rev=390323&r1=390322&r2=390323&view=diff
==============================================================================
--- 
maven/surefire/branches/surefire-testng/surefire-api/src/main/java/org/apache/maven/surefire/report/XMLReporter.java
 (original)
+++ 
maven/surefire/branches/surefire-testng/surefire-api/src/main/java/org/apache/maven/surefire/report/XMLReporter.java
 Thu Mar 30 20:25:25 2006
@@ -191,7 +191,7 @@
 
             if ( message != null && message.trim().length() > 0 )
             {
-                element.setAttribute( "message", message );
+                element.setAttribute( "message", escapeAttribute( message ));
 
                 element.setAttribute( "type", stackTrace.substring( 0, 
stackTrace.indexOf( ":" ) ) );
             }
@@ -257,10 +257,15 @@
 
                 property.setAttribute( "name", key );
 
-                property.setAttribute( "value", value );
+                property.setAttribute( "value", escapeAttribute( value ) );
 
             }
         }
     }
 
+    private static String escapeAttribute( String attribute )
+    {
+        // Shouldn't Xpp3Dom do this itself?
+        return attribute.replaceAll( "<", "&lt;" ).replaceAll( ">", "&gt;" );
+    }
 }


Reply via email to