svn commit: r803888 - /maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java

[vsiveton]

Author: vsiveton
Date: Thu Aug 13 14:00:16 2009
New Revision: 803888

URL: http://svn.apache.org/viewvc?rev=803888&view=rev
Log:
SUREFIRE-567: Review the Doxia Sink calls

o fixed sink calls

Modified:
    
maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java

Modified: 
maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java?rev=803888&r1=803887&r2=803888&view=diff
==============================================================================
--- 
maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
 (original)
+++ 
maven/surefire/trunk/maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/SurefireReportGenerator.java
 Thu Aug 13 14:00:16 2009
@@ -114,8 +114,6 @@
             constructFailureDetails( sink, bundle, failureList );
         }
 
-        sinkLineBreak( sink );
-
         sink.body_();
 
         sink.flush();
@@ -129,13 +127,11 @@
 
         sink.section1();
         sink.sectionTitle1();
-
-        sinkAnchor( sink, "Summary" );
-
         sink.text( bundle.getString( "report.surefire.label.summary" ) );
-
         sink.sectionTitle1_();
 
+        sinkAnchor( sink, "Summary" );
+
         constructHotLinks( sink, bundle );
 
         sinkLineBreak( sink );
@@ -178,7 +174,9 @@
 
         sink.lineBreak();
 
+        sink.paragraph();
         sink.rawText( bundle.getString( "report.surefire.text.note1" ) );
+        sink.paragraph_();
 
         sinkLineBreak( sink );
 
@@ -191,13 +189,11 @@
 
         sink.section1();
         sink.sectionTitle1();
-
-        sinkAnchor( sink, "Package_List" );
-
         sink.text( bundle.getString( "report.surefire.label.packagelist" ) );
-
         sink.sectionTitle1_();
 
+        sinkAnchor( sink, "Package_List" );
+
         constructHotLinks( sink, bundle );
 
         sinkLineBreak( sink );
@@ -255,7 +251,9 @@
 
         sink.lineBreak();
 
+        sink.paragraph();
         sink.rawText( bundle.getString( "report.surefire.text.note2" ) );
+        sink.paragraph_();
 
         packIter = suitePackages.keySet().iterator();
 
@@ -269,13 +267,11 @@
 
             sink.section2();
             sink.sectionTitle2();
-
-            sinkAnchor( sink, packageName );
-
             sink.text( packageName );
-
             sink.sectionTitle2_();
 
+            sinkAnchor( sink, packageName );
+
             sink.table();
 
             sink.tableRow();
@@ -369,13 +365,11 @@
 
         sink.section1();
         sink.sectionTitle1();
-
-        sinkAnchor( sink, "Test_Cases" );
-
         sink.text( bundle.getString( "report.surefire.label.testcases" ) );
-
         sink.sectionTitle1_();
 
+        sinkAnchor( sink, "Test_Cases" );
+
         constructHotLinks( sink, bundle );
 
         ListIterator suiteIterator = testSuites.listIterator();
@@ -392,13 +386,11 @@
 
                 sink.section2();
                 sink.sectionTitle2();
-
-                sinkAnchor( sink, suite.getPackageName() + suite.getName() );
-
                 sink.text( suite.getName() );
-
                 sink.sectionTitle2_();
 
+                sinkAnchor( sink, suite.getPackageName() + suite.getName() );
+
                 sink.table();
 
                 while ( caseIterator.hasNext() )
@@ -517,13 +509,11 @@
         {
             sink.section1();
             sink.sectionTitle1();
-
-            sinkAnchor( sink, "Failure_Details" );
-
             sink.text( bundle.getString( 
"report.surefire.label.failuredetails" ) );
-
             sink.sectionTitle1_();
 
+            sinkAnchor( sink, "Failure_Details" );
+
             constructHotLinks( sink, bundle );
 
             sinkLineBreak( sink );