Hi Kenney,

Would be interested to get your thoughts on the issues being seen with useSystemClassLoader and the reasoning for going with a JAR to execute it that way. Before I can continue with the release I need to put them to bed.

- Brett

On 25/05/2007, at 5:01 PM, Brett Porter wrote:

I'm starting to find a number of bugs related to useSystemClassLoader, by virtue of it being a forked JAR call. I'd be interested to get more input on why this route was taken and how the classloading in general works now (would be a handy document to have).

Cheers,
Brett

On 24/05/2007, at 7:39 PM, Brett Porter wrote:

Hi Kenney,

Are you able to comment on whether this is a correct solution? You added this feature in http://svn.apache.org/viewvc? view=rev&revision=489098

Also, can you check whether http://jira.codehaus.org/browse/ SUREFIRE-117? page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel should be closed as fixed as it was originally, and a new issue created for their problems, or if it wasn't in fact fixed?

Thanks!

- Brett

On 24/05/2007, at 7:33 PM, [EMAIL PROTECTED] wrote:

Author: brett
Date: Thu May 24 02:33:01 2007
New Revision: 541236

URL: http://svn.apache.org/viewvc?view=rev&rev=541236
Log:
[SUREFIRE-326] make it the default to use the system classloader, for consistency with surefire 2.2

Modified:
maven/surefire/branches/surefire-2.3.x/maven-surefire-plugin/ src/main/java/org/apache/maven/plugin/surefire/SurefirePlugin.java

Modified: maven/surefire/branches/surefire-2.3.x/maven-surefire- plugin/src/main/java/org/apache/maven/plugin/surefire/ SurefirePlugin.java URL: http://svn.apache.org/viewvc/maven/surefire/branches/ surefire-2.3.x/maven-surefire-plugin/src/main/java/org/apache/ maven/plugin/surefire/SurefirePlugin.java? view=diff&rev=541236&r1=541235&r2=541236 ==================================================================== ========== --- maven/surefire/branches/surefire-2.3.x/maven-surefire-plugin/ src/main/java/org/apache/maven/plugin/surefire/ SurefirePlugin.java (original) +++ maven/surefire/branches/surefire-2.3.x/maven-surefire-plugin/ src/main/java/org/apache/maven/plugin/surefire/ SurefirePlugin.java Thu May 24 02:33:01 2007
@@ -379,7 +379,7 @@
* forking. Prevents problems with JDKs which implement the service provider lookup mechanism by using
      * the system's classloader.
      *
- * @parameter expression="${surefire.useSystemClassLoader}" default-value="false" + * @parameter expression="${surefire.useSystemClassLoader}" default-value="true"
      */
     private boolean useSystemClassLoader;


Reply via email to