Hi!
> > > any Internet access.
> >
> > So you should be back by now? ;-).
>
> I am. :-)
Good ;-).
> > tty-console-suspend-resume-fix.patch ... if it works for you, it is
> > good enough for merge. ACK.
>
> Heh, this thing was vetoed by Linus. I use it locally, because it fixes the
> problem for me, but it's more of a workaround than a fix. BTW, its not
> needed with the next one.
Ok, so lets use the next one.
> > hack-serial-suspend.patch ... it is really a hack, but we want serial
> > console to work. rmk needs to sign this off, but it looks okay. ACK.
>
> I'm a bit reluctant about this one. It may result in a garbage being sent
> over the serial line after the resume (it's happended to me once in a couple
> of months, but still).
Garbage once-a-month is better than garbage-always, I'd say.
> > pm-add-pm_trace-switch.patch ... I'm not sure if it is in or not, but
> > this one is needed. ACK.
>
> I have to check. If it's not in, I'll resend it.
Thanks.
> > swsusp-handle-highmem-better.patch ... I've reviewed this before. It
> > is a little complex, and I hope highmem just dies... it probably can
> > go in after lots of testing.
>
> I'd like to send this one for -mm after 2.6.19-rc1 is out, as potential
> 2.6.20 material.
That's probably okay. (Pavel wishes highmem dies painful dead before
2.6.19-rc1 is out... so that Pavel can simply veto it as unneeded).
> > print-offset-for-swap-files.patch ... this actually changes userland
> > API. Not sure if that is acceptable; lots of discussion is needed. We
> > should probably drop /proc/swaps and just create something in sysfs.
>
> In sysfs we'd have to create a whole hierarchy of files to provide all of
> the information contained in /proc/swaps. And there would be a problem
> with file names. ;-)
>
> The procfs modification is not really needed, I added it for completness.
> The message from sys_swapon() should be enough. Or perhaps I'll
> just add a separate message in sys_swapon() containing the "real" block
> device name _and_ the offset for the newly activated swap.
Okay, lets just mark it clearly in changelog, perhaps changing
/proc/swaps is okay, perhaps not.
> > Oh, new command line options need Documenting.
>
> Sure (the patch is experimental :-) ).
Ok.
> > > In short, the idea is that a swap file can be identified by the name of
> > > the
> > > block device which holds it and the offset from the beginning of the
> > > device.
> >
> > Are you sure swap files are always contiguous on the disk? I'm pretty
> > sure that is not the case.
>
> You're right, but it doesn't matter. :-)
So... being lazy Pavel I am, could you explain how we find which
blocks belong to swap file? (Or do you use linklist of blocks for page
directories?)
Related question is -- how will we handle *huge* filesystems? Like >
32bit?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/suspend-devel
