On Sun, 3 Sep 2006 22:49:57 +0200
Pavel Machek <[EMAIL PROTECTED]> wrote:

> On Sun 2006-09-03 21:06:12, Tim Dijkstra wrote:
> > Hi,
> > 
> > If I can count, than PARAM_NO is of by one;)
> > 
> > GEN_PARAM is defined as 8, which is correct because there is no
> > #ifdef SPLASH_CONFIG anymore. SPLASH_PARAM still adds one to
> > PARAM_NO though. 
> > 
> > This crashes s2disk/resume when there's an error in the config file.
> 
> Will not your patch break splash? Ugh, I do not see how param system
> works :-(.

No it will not break. SPLASH_PARAM is only used to increment PARAM_NO
by one. PARAM_NO is used to limit the loop through all options while 
parsing the config file.

grep SPLASH_PARAM suspend-cvs/*
suspend-cvs/swsusp.h:#define SPLASH_PARAM       1
suspend-cvs/swsusp.h:#define PARAM_NO   (GEN_PARAM + COMPRESS_PARAM + 
ENCRYPT_PARAM + SPLASH_PARAM)


> 
> > --- swsusp.h--      2006-09-03 20:56:35.000000000 +0200
> > +++ swsusp.h        2006-09-03 20:56:58.000000000 +0200
> > @@ -183,6 +183,4 @@
> >  #define ENCRYPT_PARAM      0
> >  #endif
> >  
> > -#define SPLASH_PARAM       1
> > -
> > -#define PARAM_NO   (GEN_PARAM + COMPRESS_PARAM +
> > ENCRYPT_PARAM + SPLASH_PARAM) +#define PARAM_NO     (GEN_PARAM +
> > COMPRESS_PARAM + ENCRYPT_PARAM)
> 

Attachment: signature.asc
Description: PGP signature

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to