Hi!
> > > Otherwise looks okay to me.
> >
> > I'd prefer to have a variable, say use_platform_suspend, that is set to one
> > in main() if shutdown_method contains the string "platform", so that we can
> > get rid of the repeated strcmp(shutdown_method, "platform") invocations.
>
> Yes, this was basically the first incarnation of the patch, then i figured
> that a global variable might not be the best solution. I do not really care
> though, so will change that.
>
> > Also, when platform_finish() is called, the variable ret is not necessary,
> > and
> > we don't intend to implement S3 in suspend_shutdown() (s2both is for that).
>
> Ok.
>
> Next try:
ACK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
