On Sun, Feb 25, 2007 at 10:26:51PM +0100, Rafael J. Wysocki wrote: > Hi, > > I've just notice that we "forgot" to implement the "platform" mode in resume. > The appended patch fixes this problem.
I did not read the ACPI spec on this, but we never did that in the in-kernel suspend, and it seems to have worked fine until now (and actually, Patricks version seemed to be built upon reading the spec). With this change, if i read it correctly, we are preparing a suspend (during resume), without entering it. Then we finish the suspend. I would not bet that this does not confuse the BIOSes that actually care about this stuff. Do you have a machine that behaves differently with this change? I don't think it will harm anybody, however, if we do not have a case where we need this, i am a bit hesitant to change any BIOS-touching codepath ;-) -- Stefan Seyfried "Any ideas, John?" "Well, surrounding them's out." ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
