Hi! > I have an ASUS-M2NPV motherboard and I have a SAMSUNG HD300LJ SATA hard-disk > and an LG GDR8164B IDE DVD-ROM. > > I am running kernel 2.6.21.5 and I noticed that after resume from S3, my > system > crashes as soon as I try to access the DVD. > Basically the crash is silent, that is there are no messages in the console. > > I have tried to apply patch in > http://bugzilla.kernel.org/show_bug.cgi?id=6840, > but it did not help. > > I managed to have DVD access OK after resume from S3 using the attached patch. > > Basically what I have done is to allow restore of PIO mode on resume also for > ide_cdrom (normally it is enabled for ide_disk only), but I don't have a > technical explanation why this is working. > > I have attached a patch of ide-io.c which works for me. > > Is anybody seeing this problem and do you have any comment about the patch ?
Patch looks okay to me. If it is still a problem in 2.6.23-rc2, you may want to send it to Tejun (and I guess Cc me and akpm). > --- linux-2.6.21.5.orig/drivers/ide/ide-io.c 2007-06-11 20:37:06.000000000 > +0200 > +++ linux-2.6.21.5/drivers/ide/ide-io.c 2007-06-16 16:49:55.000000000 > +0200 > @@ -143,7 +143,7 @@ > { > struct request_pm_state *pm = rq->data; > > - if (drive->media != ide_disk) > + if ((drive->media != ide_disk) && (drive->media != ide_cdrom)) > return; > > switch (pm->pm_step) { > @@ -172,7 +172,7 @@ > > memset(args, 0, sizeof(*args)); > > - if (drive->media != ide_disk) { > + if ((drive->media != ide_disk) && (drive->media != ide_cdrom)) { > /* > * skip idedisk_pm_restore_pio and idedisk_pm_idle for ATAPI > * devices > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Suspend-devel mailing list > Suspend-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/suspend-devel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel