On Monday, 6 August 2007 13:35, Rafael J. Wysocki wrote:
> On Monday, 6 August 2007 13:00, Alon Bar-Lev wrote:
> > On 8/6/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote:
> > > Yes, in this context you're right, but this was not clear from the
> > > original
> > > post.
> > >
> > > Moreover, the printf() is buggy, not the function itself.
> >
> > Again... we go philosophical...
> > Please fix the issue as you see it...
>
> I will, thanks for pointing out the problem.
I'm going to apply the following patch.
Greetings,
Rafael
---
resume.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
Index: suspend/resume.c
===================================================================
--- suspend.orig/resume.c
+++ suspend/resume.c
@@ -580,8 +580,8 @@ static int read_image(int dev, int fd, s
if (header->image_flags & IMAGE_CHECKSUM) {
memcpy(orig_checksum, header->checksum, 16);
- printf("resume: MD5 checksum %s\n",
- print_checksum(buffer, orig_checksum));
+ print_checksum(buffer, orig_checksum);
+ printf("resume: MD5 checksum %s\n", buffer);
verify_checksum = 1;
}
splash.progress(10);
@@ -697,8 +697,9 @@ static int read_image(int dev, int fd, s
md5_finish_ctx(&handle.ctx, checksum);
if (memcmp(orig_checksum, checksum, 16)) {
fprintf(stderr,"resume: MD5 checksum does not match\n");
- fprintf(stderr,"resume: Computed MD5 checksum %s\n",
- print_checksum(buffer, checksum));
+ print_checksum(buffer, checksum);
+ fprintf(stderr, "resume: Computed MD5 checksum %s\n",
+ buffer);
error = -EINVAL;
}
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
