Hi! > Current implementation does not cleanup console settings if abort was > selected by user. > This should fix it. > > Part of pending series at: > http://alon.barlev.googlepages.com/suspend-patches.tar.bz2 > > Best Regards, > Alon Bar-Lev. > > --- > > --- suspend.org/suspend.c 2007-07-29 21:30:27.000000000 +0300 > +++ suspend.work/suspend.c 2007-08-11 21:53:35.000000000 +0300 > @@ -498,5 +559,6 @@ static int save_image(struct swap_map_ha > case ABORT_KEY_CODE: > if (abort_possible) { > printf(" aborted!\n"); > - return -EINTR; > + error = -EINTR; > + goto cleanup; > } > @@ -513,6 +576,8 @@ static int save_image(struct swap_map_ha > nr_pages++; > } > } while (ret > 0); > + > +cleanup: > if (ret < 0) > error = -errno;
Really? You set up error, but it is going to be ignored if ret < 0. That smells wrong. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
