Author: rmudgett
Date: Thu Aug 8 12:51:26 2013
New Revision: 396401
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=396401
Log:
Remove some resolved or obsolete BUGBUG comments.
Modified:
trunk/include/asterisk/bridge_features.h
trunk/main/bridge.c
trunk/main/channel_internal_api.c
trunk/main/features.c
Modified: trunk/include/asterisk/bridge_features.h
URL:
http://svnview.digium.com/svn/asterisk/trunk/include/asterisk/bridge_features.h?view=diff&rev=396401&r1=396400&r2=396401
==============================================================================
--- trunk/include/asterisk/bridge_features.h (original)
+++ trunk/include/asterisk/bridge_features.h Thu Aug 8 12:51:26 2013
@@ -86,7 +86,6 @@
* parking slot to which it was parked.
*/
AST_BRIDGE_BUILTIN_PARKCALL,
-/* BUGBUG does Monitor and/or MixMonitor require a two party bridge?
MixMonitor is used by ConfBridge so maybe it doesn't. */
/*!
* DTMF one-touch-record toggle using Monitor app.
*
@@ -174,7 +173,6 @@
AST_BRIDGE_HOOK_TYPE_TALK,
};
-/* BUGBUG Need to be able to selectively remove DTMF, hangup, and interval
hooks. */
/*! \brief Structure that is the essence of a feature hook. */
struct ast_bridge_hook {
/*! Callback that is called when hook is tripped */
Modified: trunk/main/bridge.c
URL:
http://svnview.digium.com/svn/asterisk/trunk/main/bridge.c?view=diff&rev=396401&r1=396400&r2=396401
==============================================================================
--- trunk/main/bridge.c (original)
+++ trunk/main/bridge.c Thu Aug 8 12:51:26 2013
@@ -1482,7 +1482,6 @@
ao2_ref(bridge_channel, -1);
join_exit:;
-/* BUGBUG this is going to cause problems for DTMF atxfer attended bridge
between B & C. Maybe an ast_bridge_join_internal() that does not do the after
bridge goto for this case. */
ast_bridge_run_after_callback(chan);
if (!(ast_channel_softhangup_internal_flag(chan) &
AST_SOFTHANGUP_ASYNCGOTO)
&& !ast_bridge_setup_after_goto(chan)) {
@@ -1960,7 +1959,6 @@
int was_in_bridge;
int res = 0;
-/* BUGBUG need bridge move stasis event and a success/fail event. */
if (bridge_channel->swap) {
ast_debug(1, "Moving %p(%s) into bridge %s swapping with %s\n",
bridge_channel, ast_channel_name(bridge_channel->chan),
dst_bridge->uniqueid,
Modified: trunk/main/channel_internal_api.c
URL:
http://svnview.digium.com/svn/asterisk/trunk/main/channel_internal_api.c?view=diff&rev=396401&r1=396400&r2=396401
==============================================================================
--- trunk/main/channel_internal_api.c (original)
+++ trunk/main/channel_internal_api.c Thu Aug 8 12:51:26 2013
@@ -193,7 +193,6 @@
unsigned short transfercapability; /*!< ISDN Transfer
Capability - AST_FLAG_DIGITAL is not enough */
-/* BUGBUG the bridge pointer must change to an ast_channel_bridge pointer
because it will never change while the channel is in the bridging system
whereas the bridge could change. */
struct ast_bridge *bridge; /*!< Bridge this
channel is participating in */
struct ast_bridge_channel *bridge_channel;/*!< The bridge_channel this
channel is linked with. */
struct ast_timer *timer; /*!< timer object that
provided timingfd */
Modified: trunk/main/features.c
URL:
http://svnview.digium.com/svn/asterisk/trunk/main/features.c?view=diff&rev=396401&r1=396400&r2=396401
==============================================================================
--- trunk/main/features.c (original)
+++ trunk/main/features.c Thu Aug 8 12:51:26 2013
@@ -792,7 +792,7 @@
return res;
}
-/* BUGBUG this really should be made a private function of bridging_basic.c
after struct ast_call_feature is made an ao2 object. */
+/* BUGBUG this really should be made a private function of bridge_basic.c
after struct ast_call_feature is made an ao2 object. */
int ast_bridge_channel_setup_features(struct ast_bridge_channel
*bridge_channel)
{
int res = 0;
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
svn-commits mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/svn-commits
