Author: mjordan Revision: 425924 Modified property: svn:log Modified: svn:log at Sat Oct 18 23:06:26 2014 ------------------------------------------------------------------------------ --- svn:log (original) +++ svn:log Sat Oct 18 23:06:26 2014 @@ -1,0 +1,20 @@ +res/res_pjsip_sdp_rtp: Remove left over reference to override_prefs + +The usage of the local override_prefs variable in create_outgoing_sdp_stream +was previously to track an override format preference set by PJSIP_MEDIA_OFFER. +Now, however, that function simply sets the joint capabilities structure, +session->req_caps. During the media format rework, the override_prefs was +instead used to check if there were any formats in session->req_caps. + +However, this usage isn't useful in create_outgoing_sdp_stream. +session->req_caps contains the negotiated formats for *all* streams, not just +the current one being created. Thus, so long as any stream of any type has +provided a format, override_prefs will be non-zero. Hence, its usage in +checking whether or not we should look at the formats on the endpoint or +the joint capabilities is generally useless. + +There's only two things useful to check: +(1) Does the endpoint have a format for the media type? +(2) Did we negotiate a format for the media type? + +If either of those is a 'no', then we must kill the media stream.
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- svn-commits mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/svn-commits
