Author: mjordan
Date: Sat Nov 8 18:36:31 2014
New Revision: 427613
URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=427613
Log:
channels/chan_mgcp: Fix regression which causes gateways to be skipped
In r227276, a while loop was turned into a for loop. Unfortunately, a portion
of the while loop was left in the code such that, when a static gateway is
encountered in the list of MGCP gateways, the next gateway would be skipped.
At best, we would simply flip past a gateway; at worst, this could lead to a
crash.
ASTERISK-24500 #close
Reported by: Xavier Hienne
patches:
chan_mgcp.patch uploaded by Xavier Hienne (License 6657)
Modified:
branches/11/channels/chan_mgcp.c
Modified: branches/11/channels/chan_mgcp.c
URL:
http://svnview.digium.com/svn/asterisk/branches/11/channels/chan_mgcp.c?view=diff&rev=427613&r1=427612&r2=427613
==============================================================================
--- branches/11/channels/chan_mgcp.c (original)
+++ branches/11/channels/chan_mgcp.c Sat Nov 8 18:36:31 2014
@@ -1808,17 +1808,12 @@
/* not dynamic, check if the name matches */
} else if (name) {
if (strcasecmp(g->name, at)) {
- g = g->next;
continue;
}
/* not dynamic, no name, check if the addr matches */
} else if (!name && sin) {
if ((g->addr.sin_addr.s_addr !=
sin->sin_addr.s_addr) ||
(g->addr.sin_port != sin->sin_port)) {
- if(!g->next)
- g = find_realtime_gw(name, at,
sin);
- else
- g = g->next;
continue;
}
} else {
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
svn-commits mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/svn-commits
