Author: file Date: Mon Dec 1 07:41:43 2014 New Revision: 428656 URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=428656 Log: app_record: Fix bug where using the 'k' option and hanging up would trim 1/4 of a second of the recording.
The Record dialplan function trims 1/4 of a second from the end of recordings in case they are terminated because of DTMF. When hanging up, however, you don't want this to happen. This change makes it so on hangup this does not occur. ASTERISK-24530 #close Reported by: Ben Smithurst patches: app_record_v2.diff submitted by Ben Smithurst (license 6529) Review: https://reviewboard.asterisk.org/r/4201/ ........ Merged revisions 428653 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 428654 from http://svn.asterisk.org/svn/asterisk/branches/12 ........ Merged revisions 428655 from http://svn.asterisk.org/svn/asterisk/branches/13 Modified: trunk/ (props changed) trunk/apps/app_record.c Propchange: trunk/ ------------------------------------------------------------------------------ Binary property 'branch-13-merged' - no diff available. Modified: trunk/apps/app_record.c URL: http://svnview.digium.com/svn/asterisk/trunk/apps/app_record.c?view=diff&rev=428656&r1=428655&r2=428656 ============================================================================== --- trunk/apps/app_record.c (original) +++ trunk/apps/app_record.c Mon Dec 1 07:41:43 2014 @@ -447,8 +447,13 @@ if (gotsilence) { ast_stream_rewind(s, silence - 1000); ast_truncstream(s); - } else if (!gottimeout) { - /* Strip off the last 1/4 second of it */ + } else if (!gottimeout && f) { + /* + * Strip off the last 1/4 second of it, if we didn't end because of a timeout, + * or a hangup. This must mean we ended because of a DTMF tone and while this + * 1/4 second stripping is very old code the most likely explanation is that it + * relates to stripping a partial DTMF tone. + */ ast_stream_rewind(s, 250); ast_truncstream(s); } -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- svn-commits mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/svn-commits
