Author: kharwell
Date: Tue Jan 27 16:53:57 2015
New Revision: 431218

URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=431218
Log:
tcptls: Bad file descriptor error when reloading chan_sip

While running through some scenarios using chan_sip and tcp a problem would
occur that resulted in a flood of bad file descriptor messages on the cli:

tcptls.c:712 ast_tcptls_server_root: Accept failed: Bad file descriptor

The message is received because the underlying socket has been closed, so is
valid. This is probably happening because unloading of chan_sip is not atomic.
That however is outside the scope of this patch. This patch simply stops the
logging of multiple occurrences of that message.

ASTERISK-24728 #close
Reported by: Thomas Thompson
Review: https://reviewboard.asterisk.org/r/4380/

Modified:
    branches/11/main/tcptls.c

Modified: branches/11/main/tcptls.c
URL: 
http://svnview.digium.com/svn/asterisk/branches/11/main/tcptls.c?view=diff&rev=431218&r1=431217&r2=431218
==============================================================================
--- branches/11/main/tcptls.c (original)
+++ branches/11/main/tcptls.c Tue Jan 27 16:53:57 2015
@@ -707,8 +707,9 @@
                }
                fd = ast_accept(desc->accept_fd, &addr);
                if (fd < 0) {
-                       if ((errno != EAGAIN) && (errno != EINTR)) {
+                       if ((errno != EAGAIN) && (errno != EWOULDBLOCK) && 
(errno != EINTR) && (errno != ECONNABORTED)) {
                                ast_log(LOG_WARNING, "Accept failed: %s\n", 
strerror(errno));
+                               break;
                        }
                        continue;
                }


-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

svn-commits mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/svn-commits

Reply via email to