Author: Tobias Schlitt Date: 2006-01-16 19:09:24 +0100 (Mon, 16 Jan 2006) New Revision: 1932
Log: - Refined excption text again. - Updated todo list. Modified: packages/ConsoleTools/trunk/TODO packages/ConsoleTools/trunk/src/exceptions/option_dependency_violation.php packages/ConsoleTools/trunk/src/exceptions/option_exclusion_violation.php Modified: packages/ConsoleTools/trunk/TODO =================================================================== --- packages/ConsoleTools/trunk/TODO 2006-01-16 14:59:33 UTC (rev 1931) +++ packages/ConsoleTools/trunk/TODO 2006-01-16 18:09:24 UTC (rev 1932) @@ -1,4 +1,2 @@ - Fix issue with Gnome terminal not recognizing position restore sequence. -- Finally fix review comments by Amos (see http://lists.ez.no/pipermail/components/2005-December/000819.html). -- Check with Derick regarding default value handling in ezcConsoleInput. -(- Recheck documentation and code beauty.) +- Add generation of help tables. Modified: packages/ConsoleTools/trunk/src/exceptions/option_dependency_violation.php =================================================================== --- packages/ConsoleTools/trunk/src/exceptions/option_dependency_violation.php 2006-01-16 14:59:33 UTC (rev 1931) +++ packages/ConsoleTools/trunk/src/exceptions/option_dependency_violation.php 2006-01-16 18:09:24 UTC (rev 1932) @@ -19,10 +19,10 @@ { function __construct( ezcConsoleOption $dependingOption, ezcConsoleOption $dependantOption, $valueRange = null ) { - $message = "The option <{$dependingOption->long}> depends on the option <{$dependantOption->long}>, but this was not submitted."; + $message = "The option <{$dependingOption->long}> depends on the option <{$dependantOption->long}> "; if ( $valueRange !== null ) { - $message .= "being the value range <{$valueRange}> "; + $message .= " to have a value in <{$valueRange}> "; } $message .= "but this one was not submitted."; parent::__construct( $message ); Modified: packages/ConsoleTools/trunk/src/exceptions/option_exclusion_violation.php =================================================================== --- packages/ConsoleTools/trunk/src/exceptions/option_exclusion_violation.php 2006-01-16 14:59:33 UTC (rev 1931) +++ packages/ConsoleTools/trunk/src/exceptions/option_exclusion_violation.php 2006-01-16 18:09:24 UTC (rev 1932) @@ -17,12 +17,12 @@ */ class ezcConsoleOptionExclusionViolationException extends ezcConsoleOptionException { - function __construct( ezcConsoleOption $excludingOption, ezcConsoleOption $excludedOption, $value = null ) + function __construct( ezcConsoleOption $excludingOption, ezcConsoleOption $excludedOption, $valueRange = null ) { - $message = "The option <{$excludingOption->long}> excludes the option <{$excludedOption->long}>, but this was submitted."; + $message = "The option <{$excludingOption->long}> excludes the option <{$excludedOption->long}>" ; if ( $value !== null ) { - $message .= "having the value <{$value}> "; + $message .= "to have a value in <{$valueRange}> "; } $message .= "but this one was submitted."; parent::__construct( $message ); -- svn-components mailing list [email protected] http://lists.ez.no/mailman/listinfo/svn-components
