Author: Frederik Holljen
Date: 2006-01-18 12:19:14 +0100 (Wed, 18 Jan 2006)
New Revision: 1960
Log:
- fixed faulty id check in ezcPersistentSession::loadIntoObject
Modified:
packages/PersistentObject/trunk/ChangeLog
packages/PersistentObject/trunk/src/persistent_session.php
packages/PersistentObject/trunk/tests/persistent_session_test.php
Modified: packages/PersistentObject/trunk/ChangeLog
===================================================================
--- packages/PersistentObject/trunk/ChangeLog 2006-01-18 11:13:10 UTC (rev
1959)
+++ packages/PersistentObject/trunk/ChangeLog 2006-01-18 11:19:14 UTC (rev
1960)
@@ -1,3 +1,7 @@
+1.0 - [RELEASEDATE]
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+- Fixed faulty numeric id check in ezcPersistentSession::loadIntoObject()
+
1.0rc1 - Monday 16 January 2006
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Modified: packages/PersistentObject/trunk/src/persistent_session.php
===================================================================
--- packages/PersistentObject/trunk/src/persistent_session.php 2006-01-18
11:13:10 UTC (rev 1959)
+++ packages/PersistentObject/trunk/src/persistent_session.php 2006-01-18
11:19:14 UTC (rev 1960)
@@ -509,7 +509,7 @@
*/
public function loadIntoObject( $pObject, $id )
{
- if( !is_int( $id ) )
+ if( !is_numeric( $id ) )
{
throw new ezcPersistentQueryException( "The parameter 'id' was not
a valid integer." );
}
@@ -517,7 +517,8 @@
$def = $this->manager->fetchDefinition( get_class( $pObject ) ); //
propagate exception
$q = $this->db->createSelectQuery();
$q->select( '*' )->from( $def->table )
- ->where( $q->expr->eq( $def->idProperty->columnName, $id ) );
+ ->where( $q->expr->eq( $def->idProperty->columnName,
+ $q->bindValue( $id ) ) );
try
{
$stmt = $q->prepare();
Modified: packages/PersistentObject/trunk/tests/persistent_session_test.php
===================================================================
--- packages/PersistentObject/trunk/tests/persistent_session_test.php
2006-01-18 11:13:10 UTC (rev 1959)
+++ packages/PersistentObject/trunk/tests/persistent_session_test.php
2006-01-18 11:19:14 UTC (rev 1960)
@@ -70,7 +70,7 @@
// class name is not a persistent object
public function testLoadValid()
{
- $object = $this->session->load( 'PersistentTestObject', 1 );
+ $object = $this->session->load( 'PersistentTestObject', "1" );
$this->assertEquals( 'PersistentTestObject', get_class( $object ) );
}
--
svn-components mailing list
[email protected]
http://lists.ez.no/mailman/listinfo/svn-components
