On Sun, Nov 9, 2008 at 3:48 AM, Alexey Dokuchaev <[EMAIL PROTECTED]> wrote: > On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote: >> >> +void >> +static remove_tmp(int sig) >> +{ >> + if (tmp_path) { >> + unlink(tmp_path); >> + } >> + exit(ERROR_EXIT); >> +} > > This looks weird: `static' should be on same line as `void' as `static > void' (so ^remove_tmp would match). It will also always exit with > ERROR_EXIT, which does not look right, does it?
Sure. I reverted the file back to the previous revision. I got other comments which suggest I should work on a better version of the patch. I'll do it later today... Sorry for the noise. Best regards -- Matteo Riondato FreeBSD Committer (http://www.freebsd.org) G.U.F.I. Staff Member (http://www.gufi.org) FreeSBIE Developer (http://www.freesbie.org) _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"