On Mon, 13 Apr 2009, Ed Schouten wrote:

Because the changes in r190919 did contain some nice fixes, but some of
them were unneeded or should not attempted to be fixed here, I've
decided to prepare a commit to revert the changes made in r190919,
except the improvements Christoph made to the inline assembly.

        http://80386.nl/pub/cmallon.diff

Review of what I can quote easily in mail: this url appears to be
syntactically correct.

This is OK, but I would prefer to use temporary hacks in machdep.c
than to mess up cpufunc.h with macros.  Temporary until machdep.c is
done right.  In one right version, a file other than machdep.c would
provide all the functions in cpufunc.h as extern functions callable
by ddb, and _all_ the functions in cpufunc.h certainly shouldn't be
messed up with macros.

Bruce
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to