Hello John, * John Baldwin <j...@freebsd.org> wrote: > When I performed similar changes in lpt(4) I stored the flags in si_drv2 > instead of the minor number. You might want to do the same here so the > drivers are closer.
I guess in the very far future we'll hopefully just get rid of dev2unit() and allow the struct field that stores the unit number (si_drv0) to be used by the drivers directly. An advantage of the unit number is that it's an integer type, unlike si_drv1 and si_drv2. I guess it's good to just leave it the way it is right now, because it was the least intrusive way to fix it like this and best of all, if I ever get the chance to remove dev2unit(), I'm forced to let it use si_drv0 instead of keeping evil casts from/to pointers. -- Ed Schouten <e...@80386.nl> WWW: http://80386.nl/
pgp6GQ9vfxCVZ.pgp
Description: PGP signature
