On Thu, 3 Dec 2015, Bryan Drewery wrote:
On 12/3/2015 7:38 PM, Kenneth D. Merry wrote:g_disk_limit(struct disk *dp, struct bio *bp) { bool limited = false; - off_t d_maxsize; - - d_maxsize = (bp->bio_cmd == BIO_DELETE) ? - dp->d_delmaxsize : dp->d_maxsize; + off_t maxsz = g_disk_maxsize(dp, bp);This looks like a style issue.
This looks like 5 style bugs and 0 issues: 3 old style bugs: - use of bool - initialization in declaration - unsorted declarations 2 new style bugs: - another initialization in declaration. A larger one - lost blank line after declarations. sys/geom had no instances of the bool style bug as recently as last month. At the top level, it didn't even use boolean_t. In subdirectories, it used boolean_t on 33 lines. Bruce _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
