I wanted to more verbose in case of the system don't have partition o n disk (or the EFI implementation only support raw disks like U-Boot) but this might be a bad way of doing saw, I didn't think about the implication you're talking about. I'll try to figure a better way to do this.
On Wed, 8 Jun 2016 22:21:36 -0400 Warner Losh <wl...@bsdimp.com> wrote: > > > On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot <m...@freebsd.org> wrote: > > > > Author: manu > > Date: Thu Jun 9 02:02:50 2016 > > New Revision: 301714 > > URL: https://svnweb.freebsd.org/changeset/base/301714 > > > > Log: > > Print a message when the efi disk isn't a logical partition. > > Why on earth would you do that? This will print a message, one per full disk, > and our systems have 36 disks in them? > Please consider backing this out... > > Warner > > > > Approved by: andrew (mentor) > > Differential Revision: https://reviews.freebsd.org/D6782 > > > > Modified: > > head/sys/boot/efi/libefi/efipart.c > > > > Modified: head/sys/boot/efi/libefi/efipart.c > > ============================================================================== > > --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 > > (r301713) > > +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 > > (r301714) > > @@ -119,8 +119,11 @@ efipart_init(void) > > (void**)&blkio); > > if (EFI_ERROR(status)) > > continue; > > - if (!blkio->Media->LogicalPartition) > > + if (!blkio->Media->LogicalPartition) { > > + printf("%s%d isn't a logical partition, skipping\n", > > + efipart_dev.dv_name, n); > > continue; > > + } > > > > /* > > * If we come across a logical partition of subtype CDROM > > -- Emmanuel Vadot _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
