Author: hselasky
Date: Fri Sep 16 11:40:45 2016
New Revision: 305871
URL: https://svnweb.freebsd.org/changeset/base/305871

Log:
  mlx5en: Optimise away duplicate UAR pointers.
  
  This change also reduces the size of the mlx5e_sq structure so that the last
  queue_state element will fit into the previous cacheline and then the mlx5e_sq
  structure becomes one cacheline less for amd64.
  
  Sponsored by: Mellanox Technologies
  MFC after:    1 week

Modified:
  head/sys/dev/mlx5/mlx5_en/en.h
  head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Modified: head/sys/dev/mlx5/mlx5_en/en.h
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/en.h      Fri Sep 16 11:39:15 2016        
(r305870)
+++ head/sys/dev/mlx5/mlx5_en/en.h      Fri Sep 16 11:40:45 2016        
(r305871)
@@ -528,8 +528,7 @@ struct mlx5e_sq {
 
        /* read only */
        struct  mlx5_wq_cyc wq;
-       void    __iomem *uar_map;
-       void    __iomem *uar_bf_map;
+       struct  mlx5_uar uar;
        struct  ifnet *ifp;
        u32     sqn;
        u32     bf_buf_size;
@@ -538,7 +537,6 @@ struct mlx5e_sq {
 
        /* control path */
        struct  mlx5_wq_ctrl wq_ctrl;
-       struct  mlx5_uar uar;
        struct  mlx5e_priv *priv;
        int     tc;
        unsigned int queue_state;
@@ -780,13 +778,13 @@ mlx5e_tx_notify_hw(struct mlx5e_sq *sq, 
        wmb();
 
        if (bf_sz) {
-               __iowrite64_copy(sq->uar_bf_map + ofst, wqe, bf_sz);
+               __iowrite64_copy(sq->uar.bf_map + ofst, wqe, bf_sz);
 
                /* flush the write-combining mapped buffer */
                wmb();
 
        } else {
-               mlx5_write64(wqe, sq->uar_map + ofst, NULL);
+               mlx5_write64(wqe, sq->uar.map + ofst, NULL);
        }
 
        sq->bf_offset ^= sq->bf_buf_size;

Modified: head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c    Fri Sep 16 11:39:15 2016        
(r305870)
+++ head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c    Fri Sep 16 11:40:45 2016        
(r305871)
@@ -956,8 +956,6 @@ mlx5e_create_sq(struct mlx5e_channel *c,
                goto err_unmap_free_uar;
 
        sq->wq.db = &sq->wq.db[MLX5_SND_DBR];
-       sq->uar_map = sq->uar.map;
-       sq->uar_bf_map = sq->uar.bf_map;
        sq->bf_buf_size = (1 << MLX5_CAP_GEN(mdev, log_bf_reg_size)) / 2;
 
        err = mlx5e_alloc_sq_db(sq);
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to