Author: ivadasz
Date: Mon Sep 19 22:08:47 2016
New Revision: 306000
URL: https://svnweb.freebsd.org/changeset/base/306000

Log:
  [iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type.
  
  The wantresp field in struct iwm_rx_data has never been used for anything,
  so we can just delete it.
  
  Apparently struct iwm_sf_cfg_cmd was compiled correctly (using a 32bit
  value to represent the enum), but it still seems like a very bad idea to use
  an enum type in a __packed struct.
  
  Approved by:  adrian (mentor)
  Differential Revision:        https://reviews.freebsd.org/D7930

Modified:
  head/sys/dev/iwm/if_iwmreg.h
  head/sys/dev/iwm/if_iwmvar.h

Modified: head/sys/dev/iwm/if_iwmreg.h
==============================================================================
--- head/sys/dev/iwm/if_iwmreg.h        Mon Sep 19 22:06:00 2016        
(r305999)
+++ head/sys/dev/iwm/if_iwmreg.h        Mon Sep 19 22:08:47 2016        
(r306000)
@@ -3251,7 +3251,7 @@ enum iwm_sf_scenario {
  * @full_on_timeouts: timer values for each scenario in full on state.
  */
 struct iwm_sf_cfg_cmd {
-       enum iwm_sf_state state;
+       uint32_t state;
        uint32_t watermark[IWM_SF_TRANSIENT_STATES_NUMBER];
        uint32_t 
long_delay_timeouts[IWM_SF_NUM_SCENARIO][IWM_SF_NUM_TIMEOUT_TYPES];
        uint32_t 
full_on_timeouts[IWM_SF_NUM_SCENARIO][IWM_SF_NUM_TIMEOUT_TYPES];

Modified: head/sys/dev/iwm/if_iwmvar.h
==============================================================================
--- head/sys/dev/iwm/if_iwmvar.h        Mon Sep 19 22:06:00 2016        
(r305999)
+++ head/sys/dev/iwm/if_iwmvar.h        Mon Sep 19 22:08:47 2016        
(r306000)
@@ -275,7 +275,6 @@ struct iwm_tx_ring {
 struct iwm_rx_data {
        struct mbuf     *m;
        bus_dmamap_t    map;
-       int             wantresp;
 };
 
 struct iwm_rx_ring {
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to