On Wed, Oct 19, 2016 at 04:45:21PM -0600, Warner Losh wrote: > What missing quotes? It seemed to work find on the system I brought up...
In ${root_rw_mount#[Yy][Ee][Ss]} with root_rw_mount=YES, the substring operation results in an empty string, which is removed because there are no quotes. This makes the test expression invalid. The result, with /firstboot existing, is two messages "[: =: unexpected operator" and an attempt to mount / read-only. > I didn't do the case statement because it would be three extra big > useless syntactical boogers in the code :) Fair enough. > I do like the idea of using checkyesno. It probably makes sense to change etc/rc.d/root to use checkyesno. This ensures behaviour with invalid values is exactly the same. -- Jilles Tjoelker _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"