Author: danfe (ports committer)
Date: Thu Dec 1 14:31:05 2016
New Revision: 309361
URL: https://svnweb.freebsd.org/changeset/base/309361
Log:
- Mention mismatching numbers in MSR vs. ACPI _PSS count warning: seeing
actual numbers would help debugging (also, `MSR' and `ACPI' are standard
abbreviations and thus should be properly capitalized)
- Rephrase unsupported AMD CPUs message and wrap as an overly long line:
`sorry' 1) is wrongly spelled after period (starts with a small letter)
and 2) carries emotional "tinge" that is unnecessary and even bogus in
debug message; `implemented' is not the best word as `supported' suits
better in this context
- Improve readability when reporting resulted P-state transition (debug)
Approved by: jhb
Modified:
head/sys/x86/cpufreq/hwpstate.c
Modified: head/sys/x86/cpufreq/hwpstate.c
==============================================================================
--- head/sys/x86/cpufreq/hwpstate.c Thu Dec 1 14:28:37 2016
(r309360)
+++ head/sys/x86/cpufreq/hwpstate.c Thu Dec 1 14:31:05 2016
(r309361)
@@ -198,7 +198,7 @@ hwpstate_goto_pstate(device_t dev, int p
}
DELAY(100);
}
- HWPSTATE_DEBUG(dev, "result P%d-state on cpu%d\n",
+ HWPSTATE_DEBUG(dev, "result: P%d-state on cpu%d\n",
(int)msr, PCPU_GET(cpuid));
if (msr != id) {
HWPSTATE_DEBUG(dev, "error: loop is not enough.\n");
@@ -367,7 +367,8 @@ hwpstate_probe(device_t dev)
*/
msr = rdmsr(MSR_AMD_10H_11H_LIMIT);
if (sc->cfnum != 1 + AMD_10H_11H_GET_PSTATE_MAX_VAL(msr)) {
- HWPSTATE_DEBUG(dev, "msr and acpi _PSS count
mismatch.\n");
+ HWPSTATE_DEBUG(dev, "MSR (%jd) and ACPI _PSS (%d)"
+ " count mismatch\n", (intmax_t)msr, sc->cfnum);
error = TRUE;
}
}
@@ -427,7 +428,8 @@ hwpstate_get_info_from_msr(device_t dev)
hwpstate_set[i].freq = (100 * (fid + 0x10)) >> did;
break;
default:
- HWPSTATE_DEBUG(dev, "get_info_from_msr: AMD family
0x%02x CPU's are not implemented yet. sorry.\n", family);
+ HWPSTATE_DEBUG(dev, "get_info_from_msr: AMD family"
+ " 0x%02x CPUs are not supported yet\n", family);
return (ENXIO);
}
hwpstate_set[i].pstate_id = i;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
