Author: emaste
Date: Wed Dec 21 15:45:23 2016
New Revision: 310371
URL: https://svnweb.freebsd.org/changeset/base/310371

Log:
  bhnd: remove srand() to ensure deterministic output
  
  r310342 fixed non-deterministic nvram_map_gen.awk output and thus a non-
  reproducible bhnd(4) build by using a unique sort key.
  
  Go one step further and also remove the srand() call. There's no reason
  we want non-deterministic behaviour from this script.
  
  PR:           215422
  Reported by:  gjb (non-reproducibility of bhnd)
  Reported by:  lidl (srand as the cause)
  Reviewed by:  landonf
  Sponsored by: The FreeBSD Foundation
  Differential Revision:        https://reviews.freebsd.org/D8857

Modified:
  head/sys/dev/bhnd/tools/nvram_map_gen.awk

Modified: head/sys/dev/bhnd/tools/nvram_map_gen.awk
==============================================================================
--- head/sys/dev/bhnd/tools/nvram_map_gen.awk   Wed Dec 21 15:40:16 2016        
(r310370)
+++ head/sys/dev/bhnd/tools/nvram_map_gen.awk   Wed Dec 21 15:45:23 2016        
(r310371)
@@ -52,9 +52,6 @@ function main(_i) {
                AWK_REQ_HEX_PARSING=1
        }
 
-       # Seed rand()
-       srand()
-
        # Output type
        OUT_T = null
        OUT_T_HEADER = "HEADER"
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to