> On Mar 6, 2017, at 21:01, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> > wrote: > > >> On Mar 6, 2017, at 21:00, Rodney W. Grimes <free...@pdx.rh.cn85.dnsmgr.net> >> wrote: >> >> [ Charset UTF-8 unsupported, converting... ] >>> Author: ngie >>> Date: Tue Mar 7 04:33:17 2017 >>> New Revision: 314831 >>> URL: https://svnweb.freebsd.org/changeset/base/314831 >>> >>> Log: >>> Don't rely on dependency in Makefile.inc1 for strfile; make datfiles depend >>> on strfile >>> >>> In most cases strfile is built as part of build-tools, but in the event >>> that someone >>> cd'ed to the directory, tried to build from scratch, and had MK_GAMES=no >>> previously, >>> the build would fail in .../datfiles , trying to find strfile . >>> >>> Mark this directory tree "SUBDIR_PARALLEL" safe to help facilitate this, >>> instead of >>> shuffling around the SUBDIR entries (all of the other Makefiles will build >>> standalone). >>> >>> MFC after: 1 week >>> Sponsored by: Dell EMC Isilon >>> >>> Modified: >>> head/usr.bin/fortune/Makefile >>> >>> Modified: head/usr.bin/fortune/Makefile >>> ============================================================================== >>> --- head/usr.bin/fortune/Makefile Tue Mar 7 04:13:22 2017 >>> (r314830) >>> +++ head/usr.bin/fortune/Makefile Tue Mar 7 04:33:17 2017 >>> (r314831) >>> @@ -1,5 +1,11 @@ >>> # @(#)Makefile 8.1 (Berkeley) 5/31/93 >>> +# >>> +# $FreeBSD$ >>> >>> -SUBDIR= fortune strfile datfiles unstr >>> +SUBDIR= fortune strfile datfiles unstr >>> + >>> +SUBDIR_DEPEND_datfiles= strfile >> That should be a space, variable ends past column 9. > > "An ASCII space is allowed for variable names that extend beyond column 9. “ > > "is allowed” != “must”.
And being extremely aesthetically nitpicky, as the queer person I am with my attention to colors and design (:P..), I would be kind of annoyed with right hand sides being unaligned, e.g., SOMETHING_REALLY_LONG= foo # 1 hard tab SOMETHING_SHORTER= bar # 2 hard tabs vs SOMETHING_REALLY_LONG= foo # 1 space SOMETHING_SHORTER= bar # 2 spaces
signature.asc
Description: Message signed with OpenPGP using GPGMail
