On Wed, Mar 08, 2017 at 07:47:13PM +1100, Bruce Evans wrote: B> > On 08/03/2017 00:17, Gleb Smirnoff wrote: B> >> On Tue, Mar 07, 2017 at 03:43:49PM +0000, Andriy Gapon wrote: B> >> A> Author: avg B> >> A> Date: Tue Mar 7 15:43:49 2017 B> >> A> New Revision: 314862 B> >> A> URL: https://svnweb.freebsd.org/changeset/base/314862 B> >> A> B> >> A> Log: B> >> A> qlxgbe: add GCC_MS_EXTENSIONS to CFLAGS to make old base GCC happy B> >> A> B> >> A> The module uses unnamed structure and union fields and base GCC in B> >> A> stable/10 doesn't like it. B> >> A> I think that that is a C11 feature, so it is courteous of more modern B> >> A> compilers to not complain about it when compiling in C99 mode. B> >> B> >> There are a lot of code in kernel, that uses anonymous structs and unions. B> >> This feature is enabled globally. Why does this module need special treatment? B> B> There is not a lot of such code. There are a lot of ugly macros like B> 'define v_rdev v_un.vu_cdev' to avoid having such code since it is B> unportable.
Bruce, I am sorry, I can't resist from asking that in a straight unpolite way: Unportable to what? Back to XX century? -- Totus tuus, Glebius. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
