On Wed, Apr 5, 2017 at 1:48 PM, Ngie Cooper (yaneurabeya) <
yaneurab...@gmail.com> wrote:
>
> As a general rule of thumb, if it doesn’t pass, it needs to be
> marked as an expected failure until it passes. Not really a big deal right
> now (because ci.freebsd.org isn’t spamming current@ — yet), but when that
> switch gets thrown again, it would spam a few hundred people with known
> failures.
>
Ah, whoops. Something like this?
diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
index b8d2a398c8d..189e3547e34 100755
--- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
+++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
@@ -234,6 +234,7 @@ oflag_zerolen_head()
}
oflag_zerolen_body()
{
+ atf_expect_fail "GNU grep's -o behavior with empty matches has known bugs
(PR 195763)"
atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
@@ -281,6 +282,7 @@ color_body()
atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
+ atf_expect_fail "GNU grep --color output does not exactly match
expectations going forward"
atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
}
diff --git a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
index b8d2a398c8d..189e3547e34 100755
--- a/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
+++ b/contrib/netbsd-tests/usr.bin/grep/t_grep.sh
@@ -234,6 +234,7 @@ oflag_zerolen_head()
}
oflag_zerolen_body()
{
+ atf_expect_fail "GNU grep's -o behavior with empty matches has known
bugs (PR 195763)"
atf_check -o file:"$(atf_get_srcdir)/d_oflag_zerolen_a.out" \
grep -Eo '(^|:)0*' "$(atf_get_srcdir)/d_oflag_zerolen_a.in"
@@ -281,6 +282,7 @@ color_body()
atf_check -o file:"$(atf_get_srcdir)/d_color_b.out" \
grep --color=auto -f grepfile "$(atf_get_srcdir)/d_color_b.in"
+ atf_expect_fail "GNU grep --color output does not exactly match BSD
grep's"
atf_check -o file:"$(atf_get_srcdir)/d_color_c.out" \
grep --color=always -f grepfile "$(atf_get_srcdir)/d_color_b.in"
}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
