Author: cem
Date: Sat Jun 3 22:30:30 2017
New Revision: 319557
URL: https://svnweb.freebsd.org/changeset/base/319557
Log:
ext2fs(4): Fix a number of broken flag checks
Introduced in r319071.
Reported by: Coverity
CIDs: 1375847, 1375848, 1375849
Sponsored by: Dell EMC Isilon
Modified:
head/sys/fs/ext2fs/ext2_acl.c
Modified: head/sys/fs/ext2fs/ext2_acl.c
==============================================================================
--- head/sys/fs/ext2fs/ext2_acl.c Sat Jun 3 21:53:58 2017
(r319556)
+++ head/sys/fs/ext2fs/ext2_acl.c Sat Jun 3 22:30:30 2017
(r319557)
@@ -276,7 +276,7 @@ ext2_getacl(struct vop_getacl_args *ap)
{
if (((ap->a_vp->v_mount->mnt_flag & MNT_ACLS) == 0) ||
- ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) == 1))
+ ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) != 0))
return (EOPNOTSUPP);
if (ap->a_type == ACL_TYPE_NFS4)
@@ -473,7 +473,7 @@ int
ext2_setacl(struct vop_setacl_args *ap)
{
if (((ap->a_vp->v_mount->mnt_flag & MNT_ACLS) == 0) ||
- ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) == 1))
+ ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) != 0))
return (EOPNOTSUPP);
if (ap->a_type == ACL_TYPE_NFS4)
@@ -490,7 +490,7 @@ ext2_aclcheck(struct vop_aclcheck_args *ap)
{
if (((ap->a_vp->v_mount->mnt_flag & MNT_ACLS) == 0) ||
- ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) == 1))
+ ((ap->a_vp->v_mount->mnt_flag & MNT_NFS4ACLS) != 0))
return (EOPNOTSUPP);
if (ap->a_type == ACL_TYPE_NFS4)
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"
