On 06/14/2017 10:52, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
>> On 06/14/2017 06:04, Hans Petter Selasky wrote:
>>> On 06/13/17 19:49, Alan Cox wrote:
>>>> +#define bitcount64(x) __bitcount64((uint64_t)(x))
>>> bitcount64() is already defined by sys/libkern.h - use that?
>> This snippet appears in code that is only used when compiling this file
>> as a user-space application for testing. Attempting to use
>> sys/libkern.h in the user-space compilation provoked warnings.
> Could we please add a comment to this define indicating this?
>
This snippet is enclosed in the #else of an #ifdef _KERNEL, where the
entire #ifdef _KERNEL is not that long, so if you're looking at the
actual file rather than a diff, it's pretty clear. And just a few lines
above the #ifdef _KERNEL is the comment:
*
* This code can be compiled stand-alone for
debugging.
*/
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"
